#110517Use indexed hashes for FAL identifier lookups
Description
FileIndexRepository currently looks up UID-less files in sys_file using (storage, identifier). This combination is not indexed, while the schema already provides an index for
(storage, identifier_hash).
Use the storage’s existing hashFileIdentifier() method and query by identifier_hash in hasIndexRecord() and the UID-less update fallback.
Benefits:
- Uses an existing database index
- Avoids full table scans as sys_file grows
- Requires no schema migration or additional index
- Improves a synthetic 100,000-row lookup from approximately 2.227 ms to 0.002 ms (~967× faster)
Add a functional test confirming that UID-less file lookups use the identifier hash.
Reviews 2
History 24
-
Gerrit Code Review pushed patch set 1 for main to change 95382 status
NewUnder Review <span data-processor="relativetime" data-value="2026-08-21T21:17:17+00:00" > 08/21/26, 21:17 </span> -
Wouter Wolters commented and changed status
Under ReviewResolved done0 %100 % <span data-processor="relativetime" data-value="2026-08-31T20:40:11+00:00" > 08/31/26, 20:40 </span> -
Gerrit Code Review pushed patch set 1 for 14.3 to change 95514 status
ResolvedUnder Review <span data-processor="relativetime" data-value="2026-09-01T09:49:47+00:00" > 09/01/26, 09:49 </span> -
Wouter Wolters changed status
Under ReviewResolved <span data-processor="relativetime" data-value="2026-09-20T13:31:35+00:00" > 09/20/26, 13:31 </span>
Applied in changeset commit:5e507873ef08ca62eb1eb356f86c94bd9a1f147c.