#110711partially written image from GraphicalFunctions::resize()
Description
GraphicalFunctions::resize() checks file_exists($output) and then has the image processor write directly to that path, with no temporary name and no rename(). Two concurrent requests resizing the same not-yet-cached image can both see “missing” and both start converting; a third request arriving in between sees file_exists($output) === true while the file is still being written, and can serve (or, with base64 embedding, read) a truncated image — which can then be cached into the page cache until the next flush.
Reviews 2
History 14
-
Gerrit Code Review pushed patch set 1 for main to change 95854 status
NewUnder Review <span data-processor="relativetime" data-value="2026-09-15T12:25:52+00:00" > 09/15/26, 12:25 </span> -
Gerrit Code Review pushed patch set 2 for main to change 95854 <span data-processor="relativetime" data-value="2026-09-15T13:12:06+00:00" > 09/15/26, 13:12 </span>
-
Gerrit Code Review pushed patch set 1 for 14.3 to change 95872 <span data-processor="relativetime" data-value="2026-09-16T10:25:32+00:00" > 09/16/26, 10:25 </span>
-
Benni Mack commented and changed status
Under ReviewResolved done0 %100 % <span data-processor="relativetime" data-value="2026-09-16T11:10:09+00:00" > 09/16/26, 11:10 </span>
Applied in changeset commit:4976c2b3bcae6c833101ea1484154c3d610cdfdf.