#110804Remove clock and random-value flakiness from tests
Description
Several tests depend on timing or random values:
CronCommandTest can cross a minute boundary between constructing the command and reading the clock.
NonceTest and RequestTokenTest use random time offsets where fixed timestamps suffice.
ResetPasswordControllerTest asserts a real delay of at least 200 ms, which is unreliable under varying test load.
Use clock readings around object creation and fixed representative timestamps. Remove the wall-clock delay assertion while leaving the password-reset delay itself unchanged.
Reviews 2
History 13
-
Gerrit Code Review pushed patch set 1 for main to change 96103 status
NewUnder Review <span data-processor="relativetime" data-value="2026-09-26T15:37:38+00:00" > 09/26/26, 15:37 </span> -
Gerrit Code Review pushed patch set 1 for 14.3 to change 96136 <span data-processor="relativetime" data-value="2026-09-28T19:05:33+00:00" > 09/28/26, 19:05 </span>
-
Wouter Wolters commented and changed status
Under ReviewResolved done0 %100 % <span data-processor="relativetime" data-value="2026-09-28T19:25:11+00:00" > 09/28/26, 19:25 </span>
Applied in changeset commit:fd0f576bb81fcf20ca5ff9319410bfaf7a2c1db9.