Issue Task Resolved

#110841Simplify HTML parser skip counter check

Wouter Wolters 09/29/26, 16:04 updated 09/30/26, 07:10

Description

The HTML parser checks that its skip counter is positive twice in one
condition. PHPStan reports the second comparison as always true, and the
finding is suppressed in the baseline. The second expression also decrements
the counter, so that decrement must be retained.

Reviews 2

History 26

  1. Wouter Wolters commented and changed status Under Review Resolved done 0 % 100 % <span data-processor="relativetime" data-value="2026-09-30T06:45:10+00:00" > 09/30/26, 06:45 </span>

    Applied in changeset commit:3f34878c12142e9fd0f67840c4174327871728b4.

  2. Gerrit Code Review pushed patch set 2 for main to change 96171 status Resolved Under Review <span data-processor="relativetime" data-value="2026-09-30T06:53:10+00:00" > 09/30/26, 06:53 </span>

  3. Wouter Wolters commented and changed status Under Review Resolved <span data-processor="relativetime" data-value="2026-09-30T07:10:10+00:00" > 09/30/26, 07:10 </span>

    Applied in changeset commit:918ca0bfec56cf113ae9a6cf5bd3e1916b52b648.