#110907options.bookmarkGroups: value 0 no longer disables a bookmark group
Description
Since the bookmark rework in 14.2 (#108796), setting a group of options.bookmarkGroups to 0 no longer disables it. BookmarkService::getGroups() only skips empty values, so “0” is shown as a group labelled “0” (plus “Global: 0”).
Up to 13.4, ShortcutRepository used !empty($label), so 0 disabled the group, and the comment in EXT:backend/Configuration/user.tsconfig still says “can be disabled by setting to 0 or empty”.
Affects main and 14.3.
Steps to reproduce
- Add to user TSconfig:
options.bookmarkGroups.2 = 0 - Open the bookmarks in the backend toolbar
Expected: the “Records” group is gone. Actual: a group “0” appears.
Reviews 2
History 24
-
Maike Kiebele changed assigned to Maike Kiebele <span data-processor="relativetime" data-value="2026-10-05T14:18:21+00:00" > 10/05/26, 14:18 </span>
-
Gerrit Code Review pushed patch set 1 for main to change 96415 status
NewUnder Review <span data-processor="relativetime" data-value="2026-10-06T14:09:42+00:00" > 10/06/26, 14:09 </span> -
Gerrit Code Review pushed patch set 1 for 14.3 to change 96432 <span data-processor="relativetime" data-value="2026-10-06T19:46:41+00:00" > 10/06/26, 19:46 </span>
-
Maike Kiebele commented and changed status
Under ReviewResolved done0 %100 % <span data-processor="relativetime" data-value="2026-10-06T20:05:09+00:00" > 10/06/26, 20:05 </span>
Applied in changeset commit:673c719e2acd98e31923ecf68053cbc57e915e5d.