#111059Correct the notificationAlternativeRecipients examples in the workspaces changelogs
Description
Problem
The changelog entries for the publish command (#108649) and the change_stage command (#108762) in 15.0 show this example:
'notificationAlternativeRecipients' => [1, 2, 3],
DataHandler passes this array unchanged to the stage change notification. StageChangeNotification::notifyStageChange() skips every entry that has no email key. The example therefore notifies nobody, and no error is shown.
The notification expects a list of arrays with the key email. The keys lang and realName are optional. The workspaces module builds this shape in WorkspacesAjaxController::getRecipientList().
If the parameter is missing or empty, nobody is notified either. Through DataHandler, the parameter is the only source of recipients; the recipients configured for the stage are not used. Neither changelog entry says so.
Solution
- Change the example in both changelog entries to the expected shape, for example
[['email' => 'editorexample.org’, ‘lang’ => ‘de’]]@. - State in both entries that nobody is notified without this parameter.
- Correct the docblocks of
DataHandlerHook::version_setStage()andDataHandlerHook::version_swap(). They describe the array parameter as “comma separated list of recipients”. - Change the recipients in
ChangeStageCommandTest::commentAndRecipientsAreWrittenToHistory()to the expected shape. The test passes a list of email strings, which would not notify anybody either.
Open question
The example [1, 2, 3] suggests that the commands were meant to accept backend user UIDs. Supporting UIDs would be a feature and is not part of this issue.
Reviews 1
History 12
-
Gerrit Code Review pushed patch set 1 for main to change 96687 status
NewUnder Review <span data-processor="relativetime" data-value="2026-10-14T15:18:38+00:00" > 10/14/26, 15:18 </span> -
Lina Wolf commented and changed status
Under ReviewResolved done0 %100 % <span data-processor="relativetime" data-value="2026-10-14T15:45:13+00:00" > 10/14/26, 15:45 </span>
Applied in changeset commit:8466beb2eef2c011dce87585c98f98f01a379b7f.