#111338Stop persisting records in invalid states due to force reload and persist
Description
Problem
When an editor changes the type field of a record (for instance CType of a content element or doktype of a page), or any field configured with 'onChange' => 'reload', FormEngine asks for confirmation, suspends its validation and saves the whole record, then loads the edit form again. The record is written in whatever state the form holds at that moment:
- a new record is created with required fields still empty,
- an existing record is saved with invalid or half-entered values,
- DataHandler hooks and events run for a save the editor never asked for,
- declining the confirmation leaves the form showing the fields of the old type.
Related reports: #36660 (required fields bypassed on type switch), #91089 (forced reload with save when editing several records), #96992 (whole record reloads after a change in a nested inline record), #107888 (record saved with an empty required field after unchecking all options of an onChange field).
Steps to reproduce
- Create a new content element of type “Text” and leave its header empty while the header is required for another type
- Change the field “Type” (CType) to another type and confirm the dialog
- See that the record is saved to the database without validation, with empty required fields
Cause
The reload of FormEngine (FormEngine.requestFormEngineUpdate() and ReloadOnFieldChange) has no way to render the form for new values other than saving the record through EditDocumentController and DataHandler: it calls Validation.suspend() and submits the form.
Reviews 1
Related issues 4
History 476
Show 051 earlier messages
-
Gerrit Code Review pushed patch set 28 for main to change 97304 status
NewUnder Review <span data-processor="relativetime" data-value="2026-11-04T11:21:56+00:00" > 11/04/26, 11:21 </span> -
Gerrit Code Review pushed patch set 29 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-04T11:31:53+00:00" > 11/04/26, 11:31 </span>
-
Gerrit Code Review pushed patch set 30 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-04T11:47:50+00:00" > 11/04/26, 11:47 </span>
-
Gerrit Code Review pushed patch set 31 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-04T14:00:13+00:00" > 11/04/26, 14:00 </span>
-
Gerrit Code Review pushed patch set 32 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-04T14:52:03+00:00" > 11/04/26, 14:52 </span>
-
Gerrit Code Review pushed patch set 33 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-04T16:18:25+00:00" > 11/04/26, 16:18 </span>
-
Gerrit Code Review pushed patch set 34 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-04T16:56:26+00:00" > 11/04/26, 16:56 </span>
-
Gerrit Code Review pushed patch set 35 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-04T17:17:34+00:00" > 11/04/26, 17:17 </span>
-
Gerrit Code Review pushed patch set 36 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-04T17:26:18+00:00" > 11/04/26, 17:26 </span>
-
Gerrit Code Review pushed patch set 37 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-04T18:15:55+00:00" > 11/04/26, 18:15 </span>
-
Gerrit Code Review pushed patch set 38 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-04T19:28:33+00:00" > 11/04/26, 19:28 </span>
-
Gerrit Code Review pushed patch set 39 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-04T19:48:13+00:00" > 11/04/26, 19:48 </span>
-
Gerrit Code Review pushed patch set 40 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-04T21:04:03+00:00" > 11/04/26, 21:04 </span>
-
Gerrit Code Review pushed patch set 41 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-04T22:13:32+00:00" > 11/04/26, 22:13 </span>
-
Gerrit Code Review pushed patch set 42 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-04T23:12:57+00:00" > 11/04/26, 23:12 </span>
-
Gerrit Code Review pushed patch set 43 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-05T00:17:28+00:00" > 11/05/26, 00:17 </span>
-
Gerrit Code Review pushed patch set 44 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-05T02:28:00+00:00" > 11/05/26, 02:28 </span>
-
Gerrit Code Review pushed patch set 45 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-05T03:05:29+00:00" > 11/05/26, 03:05 </span>
-
Gerrit Code Review pushed patch set 46 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-05T08:45:17+00:00" > 11/05/26, 08:45 </span>
-
Gerrit Code Review pushed patch set 47 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-05T09:29:09+00:00" > 11/05/26, 09:29 </span>
-
Gerrit Code Review pushed patch set 48 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-05T09:35:40+00:00" > 11/05/26, 09:35 </span>
-
Gerrit Code Review pushed patch set 49 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-05T10:37:28+00:00" > 11/05/26, 10:37 </span>
-
Gerrit Code Review pushed patch set 50 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-05T12:47:52+00:00" > 11/05/26, 12:47 </span>
-
Gerrit Code Review pushed patch set 51 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-05T16:52:55+00:00" > 11/05/26, 16:52 </span>
-
Gerrit Code Review pushed patch set 52 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-05T17:59:09+00:00" > 11/05/26, 17:59 </span>
-
Gerrit Code Review pushed patch set 53 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-05T18:34:30+00:00" > 11/05/26, 18:34 </span>
-
Gerrit Code Review pushed patch set 54 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-05T19:08:56+00:00" > 11/05/26, 19:08 </span>
-
Gerrit Code Review pushed patch set 55 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-05T20:22:09+00:00" > 11/05/26, 20:22 </span>
-
Gerrit Code Review pushed patch set 56 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-05T22:15:58+00:00" > 11/05/26, 22:15 </span>
-
Gerrit Code Review pushed patch set 57 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-06T01:00:40+00:00" > 11/06/26, 01:00 </span>
-
Gerrit Code Review pushed patch set 58 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-06T02:54:25+00:00" > 11/06/26, 02:54 </span>
-
Gerrit Code Review pushed patch set 59 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-06T03:06:58+00:00" > 11/06/26, 03:06 </span>
-
Gerrit Code Review pushed patch set 60 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-06T03:39:38+00:00" > 11/06/26, 03:39 </span>
-
Gerrit Code Review pushed patch set 61 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-06T05:15:48+00:00" > 11/06/26, 05:15 </span>
-
Gerrit Code Review pushed patch set 62 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-06T08:54:30+00:00" > 11/06/26, 08:54 </span>
-
Gerrit Code Review pushed patch set 63 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-06T10:18:02+00:00" > 11/06/26, 10:18 </span>
-
Gerrit Code Review pushed patch set 64 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-06T11:11:52+00:00" > 11/06/26, 11:11 </span>
-
Gerrit Code Review pushed patch set 65 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-06T11:24:14+00:00" > 11/06/26, 11:24 </span>
-
Gerrit Code Review pushed patch set 66 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-06T11:42:12+00:00" > 11/06/26, 11:42 </span>
-
Gerrit Code Review pushed patch set 67 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-06T15:15:12+00:00" > 11/06/26, 15:15 </span>
-
Gerrit Code Review pushed patch set 68 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-06T18:40:53+00:00" > 11/06/26, 18:40 </span>
-
Gerrit Code Review pushed patch set 69 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-06T19:40:54+00:00" > 11/06/26, 19:40 </span>
-
Gerrit Code Review pushed patch set 70 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-06T20:48:56+00:00" > 11/06/26, 20:48 </span>
-
Gerrit Code Review pushed patch set 71 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-09T12:55:54+00:00" > 11/09/26, 12:55 </span>
-
Gerrit Code Review pushed patch set 72 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-10T10:11:30+00:00" > 11/10/26, 10:11 </span>
-
Gerrit Code Review pushed patch set 73 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-10T14:42:41+00:00" > 11/10/26, 14:42 </span>
-
Gerrit Code Review pushed patch set 74 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-10T15:30:25+00:00" > 11/10/26, 15:30 </span>
-
Gerrit Code Review pushed patch set 75 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-11T08:50:13+00:00" > 11/11/26, 08:50 </span>
-
Gerrit Code Review pushed patch set 76 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-11T09:03:45+00:00" > 11/11/26, 09:03 </span>
-
Gerrit Code Review pushed patch set 77 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-11T09:32:30+00:00" > 11/11/26, 09:32 </span>
-
Gerrit Code Review pushed patch set 78 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-11T09:51:18+00:00" > 11/11/26, 09:51 </span>
-
Gerrit Code Review pushed patch set 79 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-11T13:42:46+00:00" > 11/11/26, 13:42 </span>
-
Georg Ringer changed Related to #108990 <span data-processor="relativetime" data-value="2026-11-12T17:04:56+00:00" > 11/12/26, 17:04 </span>
-
Gerrit Code Review pushed patch set 80 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-13T14:15:35+00:00" > 11/13/26, 14:15 </span>
-
Gerrit Code Review pushed patch set 81 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-13T15:17:30+00:00" > 11/13/26, 15:17 </span>
-
Gerrit Code Review pushed patch set 82 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-13T16:42:15+00:00" > 11/13/26, 16:42 </span>
-
Gerrit Code Review pushed patch set 83 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-13T20:58:18+00:00" > 11/13/26, 20:58 </span>
-
Gerrit Code Review pushed patch set 84 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-13T21:40:41+00:00" > 11/13/26, 21:40 </span>
-
Gerrit Code Review pushed patch set 85 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-16T14:19:21+00:00" > 11/16/26, 14:19 </span>
-
Gerrit Code Review pushed patch set 86 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-16T18:37:00+00:00" > 11/16/26, 18:37 </span>
-
Gerrit Code Review pushed patch set 87 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-16T19:55:14+00:00" > 11/16/26, 19:55 </span>
-
Gerrit Code Review pushed patch set 88 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-17T08:17:34+00:00" > 11/17/26, 08:17 </span>
-
Gerrit Code Review pushed patch set 89 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-17T08:41:40+00:00" > 11/17/26, 08:41 </span>
-
Gerrit Code Review pushed patch set 90 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-17T08:50:43+00:00" > 11/17/26, 08:50 </span>
-
Gerrit Code Review pushed patch set 91 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-17T09:09:30+00:00" > 11/17/26, 09:09 </span>
-
Gerrit Code Review pushed patch set 92 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-17T09:50:08+00:00" > 11/17/26, 09:50 </span>
-
Gerrit Code Review pushed patch set 93 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-17T10:03:39+00:00" > 11/17/26, 10:03 </span>
-
Gerrit Code Review pushed patch set 94 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-17T15:06:52+00:00" > 11/17/26, 15:06 </span>
-
Gerrit Code Review pushed patch set 95 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-17T15:09:10+00:00" > 11/17/26, 15:09 </span>
-
Gerrit Code Review pushed patch set 96 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-18T15:27:07+00:00" > 11/18/26, 15:27 </span>
-
Gerrit Code Review pushed patch set 97 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-18T15:54:40+00:00" > 11/18/26, 15:54 </span>
-
Gerrit Code Review pushed patch set 98 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-18T23:06:22+00:00" > 11/18/26, 23:06 </span>
-
Georg Ringer changed Related to #36660 <span data-processor="relativetime" data-value="2026-11-20T20:20:25+00:00" > 11/20/26, 20:20 </span>
-
Georg Ringer changed Related to #96992 <span data-processor="relativetime" data-value="2026-11-20T20:21:01+00:00" > 11/20/26, 20:21 </span>
-
Gerrit Code Review pushed patch set 99 for main to change 97304 <span data-processor="relativetime" data-value="2026-11-20T20:22:10+00:00" > 11/20/26, 20:22 </span>
-
Georg Ringer changed Related to #107888 <span data-processor="relativetime" data-value="2026-11-20T20:22:10+00:00" > 11/20/26, 20:22 </span>