#111499Make the dashboard null-safe
Description
The JavaScript of the dashboard module reads values that can be missing at runtime without a check. The module keeps two pieces of nullable state, the dashboard currently shown and the widget being dragged, and its event handlers, drag and drop and rendering dereference both without a guard. The widget element does the same with its widget, which is absent while it is still being fetched. Elements returned by querySelector(), closest() and elementFromPoint() and dataset attributes are used unchecked as well.
The preset step of the dashboard wizard declares its value as a string although it starts out as null, and its task renders without an initial state. The chart initializer reads a computed style from an element it never checked for.
These places should get a guard or a fallback where the value can really be missing, so the dashboard compiles under strictNullChecks.
Reviews 2
History 14
-
Gerrit Code Review pushed patch set 9 for main to change 95427 status
NewUnder Review <span data-processor="relativetime" data-value="2026-11-18T20:52:07+00:00" > 11/18/26, 20:52 </span> -
Gerrit Code Review pushed patch set 1 for 14.3 to change 97809 <span data-processor="relativetime" data-value="2026-11-18T21:21:08+00:00" > 11/18/26, 21:21 </span>
-
Gerrit Code Review pushed patch set 2 for 14.3 to change 97809 <span data-processor="relativetime" data-value="2026-11-18T21:25:04+00:00" > 11/18/26, 21:25 </span>
-
Benjamin Kott commented and changed status
Under ReviewResolved done0 %100 % <span data-processor="relativetime" data-value="2026-11-18T21:50:12+00:00" > 11/18/26, 21:50 </span>
Applied in changeset commit:84fbec63e390c07e7ba70db218fa890750a6252a.