#14391fasten up if clause class t3lib_stdGraphic in function imageMagickConvert
Description
I was searching for an error in different files, and while searching I found this row in class t3lib_stdGraphic in function imageMagickConvert
if (!$this->file_exists_typo3temp_file($output,$imagefile) || $this->dontCheckForExistingTempFile) {
$this->imageMagickExec($imagefile.$frame,$output,$command);
}
this could be better
if ($this->dontCheckForExistingTempFile || !$this->file_exists_typo3temp_file($output,$imagefile)) { …
because if will not proof it the file exists if it doesn’t matter, and
an sql select fewer is done.
New line should be :
if ($this->dontCheckForExistingTempFile || !$this->file_exists_typo3temp_file($output,$imagefile)){
(issue imported from #M508)
Reviews 0
No change resolves or names this issue in its commit message, and no comment links one.