Issue Bug Closed

#15013shortcut icon syntax incorrect/incomplete

miikaawaadizi 10/08/05, 02:26 updated 08/06/10, 13:20

Description

page.shortcutIcon adds this to the page:

<link rel="SHORTCUT ICON" href="(whatever path was set in the template)">

there’s twi relative links required to catch all the browsers/platforms that might be used, for some really dumb reason … even though Micro$queak’s web page (http://www.microsoft.com/technet/prodtechnol/ie/support/tipsauth.mspx) states to use the above syntax, MSIE seems to not always like it (whilst Firefox does).

the fix is to edit tslib/class.tslib_pagegen.php (syntax confirmed from http://www.winterdrache.de/freeware/png2ico/favicon.html).

this will make MSIE find the favicon and use it in bookmarks.

find (around line 448)

<link rel="SHORTCUT ICON" href="'.htmlspecialchars($ss).'">‘;

replace with

<link rel="icon" href="'.htmlspecialchars($ss).'" type="image/x-icon">

<link rel="shortcut icon" href="'.htmlspecialchars($ss).'" type="image/x-icon">‘;
(issue imported from #M1537)

Reviews 0

No change resolves or names this issue in its commit message, and no comment links one.