Issue Bug Closed

#15291Remove commented-out code from the EM

Oliver Klee 12/17/05, 13:32 updated 08/12/06, 14:18

Description

There is lots of commented-out code in mod/tools/em/index.php. This is bad because:

1. it makes the code less readable
2. it increases the file
3. the commented-out code tends to stay there for a very long time as it is not clear when and why the code was commented out

Code that is not needed any more should be deleted. Code that is not ready for check-in should not be checked in to CVS.

I’ve attached a patch (against the current CVS) that removes that code. I’ve left one comment untouched – what shall we do with that? I propose removing them as well (or use them):

// New headers suggested by Xin:
// For now they are commented out because a) I have seen no official support yet, b) when clicking the back-link in MSIE after download you see ugly binary stuff and c) I couldn’t see a BIG difference, in particular not in Moz/Opera.
/* header(‘Content-Type: application/force-download’);
header(‘Content-Length: ‘.strlen($backUpData));
header(‘Content-Disposition: attachment; filename=’.$filename);
header(‘Content-Description: File Transfer’);
header(‘Content-Transfer-Encoding: binary’);
*/

(issue imported from #M2054)

Reviews 0

No change resolves or names this issue in its commit message, and no comment links one.