Issue Bug Closed

#16090t3lib_parsehtml_proc::TS_links_rte: external url identification leak

typo3-bahag-com 04/26/06, 11:42 updated 09/02/13, 09:22

Description

If a full qualified url to an internal network space was configured in RTE, like

<link>http://myinternalserver/abc/xyz/ >

this is transformed by TS_links_rte into

…

This happens because $urlChar is not identified as checked for single point ‘.’ only, which is not part of my internal server name. As a result the link is identified as a FILE link and on this case the typo3 siteurl is prepended.

I hotfixed this by making the condition (strstr($link_param,’//’)) a standalone OR part without asking for $urlChar. But in worst case this will also identify dirty windows-filelinks as external urls (//sambashare/folder/file.ext).

The url scheme identification should be re-evaluated with all facettes links can be defined with. It should also be re-evaluated if the typo3 site url needs to be prepended on file links (i think it does not).

This bug also affects earlier versions of typo3 (detected in 3.7), but its still there in 4.0

My fixed line #14494:
} elseif(strstr($link_param,’//’) || ($urlChar && (!$fileChar || $urlChar<$fileChar))) { // url (external): If doubleSlash or if a ‘.’ comes before a ‘/’.

(issue imported from #M3348)

Reviews 0

No change resolves or names this issue in its commit message, and no comment links one.