Issue Bug Closed

#17145incorrect patch / closed issue #17136

alexander onea 03/22/07, 14:39 updated 06/27/08, 10:49

Description

unfortunately i cannot add a note to issue #17136 because it’s closed.

the patch for issue 5266 is incomplete.

the patch tries to exclude following browser identifier
[code]
Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8.1.3) Gecko/20070309 Firefox/2.0.0.3
[/code]
with this line
[code]
HTMLArea.is_wamcom = (HTMLArea.agt.indexOf(“wamcom”) != -1) || (HTMLArea.is_gecko && HTMLArea.agt.indexOf(“1.3”) != -1 && HTMLArea.agt.indexOf(“.1.3”) == -1);
[/code]

this condition will still won’t exclude future firefox versions, example:

[code]
Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.9.1.3) Gecko/20070309 Firefox/2.0.0.3
[/code]

so the same bug will reappear in about half a year.

(issue imported from #M5279)

Reviews 0

No change resolves or names this issue in its commit message, and no comment links one.