Issue Bug Closed

#19771common.js uses undefined variable

Dmitry Dulepov 01/06/09, 17:35 updated 08/06/10, 13:23

Description

common.js contains the following blocks of code:

} else if (!json) {
    T3AJAX.showError(xhr, json);
} else {

This code is called when JSON cannot be parsed and therefore the value is undefined. So there is no point to pass it anywhere. The function T3AJAX.showError() does not use this value anyway.

The attacjed patch removes this parameter from the function call and also shows ExtJS alert instead of standard browser if ExtJS is available.

I believe that this code is responsible for showing “undefined” messages with FireBug active.

(issue imported from #M10067)

Reviews 0

No change resolves or names this issue in its commit message, and no comment links one.