Issue Bug Closed

#20604PHP casting causes workspace message to appear in Web/View

Niels Fröhling 06/10/09, 03:15 updated 08/06/10, 13:30

Description

Somehow the integer-comparison casting in PHP makes

$this->fePreview == 2

return TRUE for “$this->fePreview = 1”

You can reveal that paradox by doing:

function previewInfo()    {
if ($this->fePreview) {
if ($this->fePreview==2) {
$text = $this->fePreview . ‘ Preview of workspace …

You’ll get “1 Preview of workspace …”

Solution: change all comparisons to ===
Effects: Doesn’t show preview workspace information if no version-view or workspace-view is in effect

(issue imported from #M11311)

Reviews 0

No change resolves or names this issue in its commit message, and no comment links one.