#24346Thumbnail generation fails
Description
In class.t3lib_div.php :: imageMagickCommand the php function “escapeshellarg” is used instead of “escapeshellcmd”. This lead to an invalid imagemagick convert argument. escapeshellarg stips out single-quotes of the asterix in the argument,.
Example:
BAD:
/usr/bin/convert +profile * -sample 56×56 /home/www/xxxx/fileadmin/user_upload/content_images/2007-02.png\[0\] /home/www/xxxx/typo3temp/tmb_cc4b193897.gif’: No such file or directory
GOOD:
/usr/bin/convert +profile ‘*’ -sample 56×56 /home/www/xxxx/fileadmin/user_upload/content_images/2007-02.png\[0\] /home/www/xxxx/typo3temp/tmb_cc4b193897.gif’: No such file or directory
see add. info for patch!!
Index: class.t3lib_div.php
===============================================================
—- class.t3lib_div.php (Revision 9811)
+++ class.t3lib_div.php (Arbeitskopie)
@@ 6191,12 +6191,12 $path = escapeshellarg($path . (($command 'composite') ? $combineScript : $command) . $isExt);
// Compile the path & command
if ($im_version = 'gm') {
$switchCompositeParameters = TRUE;
- $path = escapeshellarg($path . 'gm' . $isExt) . ' ' . $command;
+ $path = escapeshellcmd($path . 'gm' . $isExt) . ' ' . $command;
} else {
if ($im_version = ‘im6’) {
$switchCompositeParameters = TRUE;
}
+ $path = escapeshellcmd($path . (($command ‘composite’) ? $combineScript : $command) . $isExt);
}
// strip profile information for thumbnails and reduce their size
(issue imported from #M16755)Reviews 0
No change resolves or names this issue in its commit message, and no comment links one.