#25800class.tx_dbal_em.php does not check successfully whether Oracle is used
Description
In method preProcessDatabaseUpdates, this is wrong
// Remapping is only mandatory for Oracle:
if ($GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['dbal']['handlerCfg']['_DEFAULT']['type'] !== 'adodb'
&& $GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['dbal']['handlerCfg']['_DEFAULT']['config']['driver'] !== 'oci8') {
// Not using Oracle
return '';
}
This should use || instead of &&:
// Remapping is only mandatory for Oracle:
if ($GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['dbal']['handlerCfg']['_DEFAULT']['type'] !== 'adodb'
|| $GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['dbal']['handlerCfg']['_DEFAULT']['config']['driver'] !== 'oci8') {
// Not using Oracle
return '';
}Reviews 0
No change resolves or names this issue in its commit message, and no comment links one.