Issue Bug Closed

#25800class.tx_dbal_em.php does not check successfully whether Oracle is used

Xavier Perseguers 04/06/11, 16:52 updated 10/02/18, 12:20

Description

In method preProcessDatabaseUpdates, this is wrong

// Remapping is only mandatory for Oracle:
if ($GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['dbal']['handlerCfg']['_DEFAULT']['type'] !== 'adodb'
        && $GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['dbal']['handlerCfg']['_DEFAULT']['config']['driver'] !== 'oci8') {

    // Not using Oracle
    return '';
}

This should use || instead of &&:

// Remapping is only mandatory for Oracle:
if ($GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['dbal']['handlerCfg']['_DEFAULT']['type'] !== 'adodb'
        || $GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['dbal']['handlerCfg']['_DEFAULT']['config']['driver'] !== 'oci8') {

    // Not using Oracle
    return '';
}

Reviews 0

No change resolves or names this issue in its commit message, and no comment links one.