#36161Include current Domain Model UID in calculated HMAC
Description
We discussed this already at T3DD12.
The calculated HMAC does not take the current domain model UID in account as one would assume, if there is a HMAC form verification.
Reviews 0
No change resolves or names this issue in its commit message, and no comment links one.
History 12
-
Alexander Schnitzler commented and changed assigned to Helmut Hummel target version 11/22/12, 09:52
-
Alexander Schnitzler changed target version 04/23/13, 23:01
-
Alexander Schnitzler commented and changed status
NewNeeds Feedback 05/01/13, 22:08Is this still necessary at all?
-
Nico de Haen commented 05/02/13, 09:59
Well it depends, I consider it an unexpected behavior, if a form is validated by the framework, based on a calculated hash, but the uid can simply be exchanged to any other UID.
In FLOW this is not a problem, since it uses UUIDs, but in extbase it misleads developers to write unsecure code… -
Anja Leichsenring changed target version 05/31/13, 15:28
-
Alexander Opitz changed project id category status
Needs FeedbackNew target version TYPO3 Version 6.2 Is Regression 0 09/15/14, 14:20 -
Helmut Hummel commented 09/16/14, 13:38
Some thoughts on this one:
This will be hard to implement as the mapping happens in PersistenObjectTypeConverter.
If we add a hmac check there, the type converter will not be generic any more and cannot be used without the hmac being present.
If we make the hmac check optional, then the developer still needs to take action (configuring the type converter to do an hmac check)Currently I have no idea how to make this secure by default.
-
Mathias Schreiber changed target version 12/23/14, 19:46
-
Benni Mack changed target version 06/15/15, 17:44
-
Susanne Moog changed target version 08/05/15, 10:28
-
Benni Mack changed target version 09/24/15, 19:21
-
Benni Mack commented and changed status
NewRejected 06/14/24, 19:58I am closing this issue, because I feel like no one is picking this up, I personally don’t think it’s worth pursuing anymore.
If you are interested in this topic, let me know, and I will re-open the ticket. You can also open a new ticket.
@Helmut: I assigned this to you as I heard you will work on the security for 6.1. Feel free to change this if I am wrong.