#36871Change whitespaces in indentions into tabs
Description
Code have to indent by tabs. There are several places in the core where spaces was used. Change them into tabs.
How to check?
I assume PHP_CodeSniffer with the TYPO3v4 standard is installed at you machine, type in the console:
phpcs -v --standard=TYPO3v4 --sniffs=TYPO3.WhiteSpace.DisallowSpaceIndent --ignore=.git,typo3/sysext/openid/lib,typo3/contrib,typo3/sysext/adodb,typo3/sysext/em/mod1/class.nusoap.php,typo3/sysext/fluid,typo3/sysext/extbase,typo3/sysext/indexed_search/class.doublemetaphone.php --extensions=php,inc /Path/To/trunk/
before apply the patch. Than apply the patch and execute phpcs again. All the violations should be gone.
I did the changes manually to see if our sniff works correctly and we do not have some false positives. As far as I can see, it works very well. After merging the patch into core I will activate this sniff on ci.typo3.org for the gerrit and the nightly job.
Reviews 3
Related issues 5
- Task #36880Change whitespaces in indentions into tabs
- Task #36882Change whitespaces in indentions into tabs
- Task #36883Change whitespaces in indentions into tabs (Sysext: Version)
- Task #36884Change whitespaces in indentions into tabs (Sysext: Workspaces)
- Task #37020Change whitespaces in indentions into tabs [Follow-up]