Issue Bug Closed

#37221Follow up #35260: Missing selection field in t3lib_TCEmain::getPreviousLocalizedRecordUid()

Felix Nagel 05/16/12, 15:09 updated 10/24/17, 20:20

Description

Please revert the patch of #35260 as its obviously wrong. Patch of #35260 was included in all branches of TYPO3 afaics, so my patch should be applied to all branches of TYPO3.

Take a look at the function getPreviousLocalizedRecordUid as in TYPO3 4.5.15. First, the whole idea of reusing $sortRow as select statement is just bad practice. Second, using a combination like “sorting,colSort” as an index for $row wont work. Third, the current implementation creates SQL like ‘ AND sorting,colPos<0 AND ‘ which wont work.

The idea of adding colSort to select was correct (the function was broken before, too!) but the proposed fix introduces new problems and fixes none.

I have no idea how this could be reviewed by three people as its pretty obvious :-/

Reviews 0

No change resolves or names this issue in its commit message, and no comment links one.