Issue Task Closed

#38332Cleanup: Useless method overriding in t3lib_file_Repository_FileCollectionRepository

Andy Grunwald 06/23/12, 20:35 updated 10/23/17, 22:15

Description

In t3lib_file_Repository_FileCollectionRepository the method findByType just calls his parent

/**
 * Finds record collection by type.
 *
 * @param string $type The type to be looked up
 * @return NULL|t3lib_file_Collection_AbstractFileCollection[]
 */
public function findByType($type) {
    return parent::findByType($type);
}

This is quite useless, because due OOP, the parent method (t3lib_collection_RecordCollectionRepository::findByType) is called, if t3lib_file_Repository_FileCollectionRepository does not provide a local / override method.

Reviews 0

No change resolves or names this issue in its commit message, and no comment links one.