Issue Bug Rejected

#39854t3lib_db->fullQuoteString unused method argument

Marek Mizera 08/16/12, 12:56 updated 08/16/12, 13:08

Description

Hello. It’s not exactly a bug, but rather anoying thing, which could also resolve in error behaviour.

method t3lib_db->fullQuoteString has second argument $table, which is unused, but does not have set default value. So if you forget to set this argument, php raise warning, which is captured with some typo3 error handler silently, but script continues without neccesary string.

So I’m proposing to set default $table value to null (in all quote string methods), remove it completelly :

file ./t3lib/class.t3lib_db.php

function fullQuoteStr($str, $table = null)
function fullQuoteArray($arr, $table = null, $noQuote = FALSE)
function quoteStr($str, $table = null)

Reviews 0

No change resolves or names this issue in its commit message, and no comment links one.