Issue Task Closed

#39928Central function to correctly (locale-aware) escape filenames and shell-args

Stefan Neufeind 08/18/12, 18:36 updated 10/19/17, 21:14

Description

The functionality below appears in 3 places in core currently (and one more currently under review).
We should add a central function for that (t3lib_div? hmm …)

Appears in:
t3lib/class.t3lib_stdgraphic.php
t3lib/thumbs.php
t3lib/file/Service/FileProcessingService.php

And patch for review at: https://review.typo3.org/9177 (feature for 6.0 possibly, feature #34227)

Taken from: t3lib/class.t3lib_stdgraphic.php
protected function wrapFileName($inputName) {
if ($GLOBALS[‘TYPO3_CONF_VARS’][‘SYS’][‘UTF8filesystem’]) {
$currentLocale = setlocale(LC_CTYPE, 0);
setlocale(LC_CTYPE, $GLOBALS[‘TYPO3_CONF_VARS’][‘SYS’][‘systemLocale’]);
}
$escapedInputName = escapeshellarg($inputName);
if ($GLOBALS[‘TYPO3_CONF_VARS’][‘SYS’][‘UTF8filesystem’]) {
setlocale(LC_CTYPE, $currentLocale);
}
return $escapedInputName;
}

Reviews 1