Issue Bug Closed

#43447admPanel.override.edit.editNoPopup = 1 doesn't work

Frank Frewer 11/29/12, 14:21 updated 01/12/20, 13:59

Description

The User TSconfig ‘admPanel.module.edit.forceNoPopup’ is deprecated, but ‘admPanel.override.edit.editNoPopup = 1’ doesn’t work.

typo3/sysext/feedit/view/class.tx_feedit_editpanel.php / function ‘editPanelLinkWrap_doWrap’:

        if ($GLOBALS['BE_USER']->uc['TSFE_adminConfig']['edit_editNoPopup'] || $GLOBALS['BE_USER']->extAdminConfig['module.']['edit.']['forceNoPopup']) {
...

$GLOBALS[‘BE_USER’]->uc[‘TSFE_adminConfig’][‘edit_editNoPopup’] is not true although ‘admPanel.override.edit.editNoPopup = 1’ is set in user TSconfig.

In typo3/sysext/cms/tslib/class.tslib_adminpanel.php / function ‘initialize’ $GLOBALS[‘BE_USER’]->uc[‘TSFE_adminConfig’][‘edit_editNoPopup’] is set only under this condition:

        if (t3lib_div::_GP('ADMCMD_editIcons')) {
            $GLOBALS['TSFE']->displayFieldEditIcons=1;
            $GLOBALS['BE_USER']->uc['TSFE_adminConfig']['edit_editNoPopup'] = 1;
        }

Should be expanded:

        if ($this->extGetFeAdminValue('edit', 'editNoPopup')) {
            $GLOBALS['BE_USER']->uc['TSFE_adminConfig']['edit_editNoPopup'] = 1;
        }
        if (t3lib_div::_GP('ADMCMD_editIcons')) {
            $GLOBALS['TSFE']->displayFieldEditIcons=1;
            $GLOBALS['BE_USER']->uc['TSFE_adminConfig']['edit_editNoPopup'] = 1;
        }

Reviews 2