#45834Detection of curlProxyServer settings buggy on upgrade to 6.0
Description
In #28344 “HTTP Request2” API was included. It supports detecting old school “curlProxyServer” settings and transfer these to the “new” setting under HTTP:
$proxyParts = explode(':', $GLOBALS['TYPO3_CONF_VARS']['SYS']['curlProxyServer'], 2);
$GLOBALS['TYPO3_CONF_VARS']['HTTP']['proxy_host'] = $proxyParts[0];
$GLOBALS['TYPO3_CONF_VARS']['HTTP']['proxy_port'] = $proxyParts[1];
This code ended up in Core/Bootstrap::transferDeprecatedCurlSettings() after namespace and bootstrapification.
I have always set up this setting like this:
$GLOBALS['TYPO3_CONF_VARS']['SYS']['curlProxyServer'] = 'http://proxy:3128';
I guess the implementator of the transferDeprecatedCurlSettings was only thinking about the “proxy:3128” kind of syntax. I end up with:
$GLOBALS['TYPO3_CONF_VARS']['HTTP']['proxy_host'] = 'http' $GLOBALS['TYPO3_CONF_VARS']['HTTP']['proxy_port'] = '//proxy:3128;
Other than that, I would also auto-set [‘HTTP’][‘adapter’] to ‘curl’ if legacy ‘curlUse’ = TRUE.
Reviews 7
- TYPO3_6-1 31880[BUGFIX] Transfer curlProxyServer to new HTTP settings
- TYPO3_6-2 31879[BUGFIX] Transfer curlProxyServer to new HTTP settings
- main 31867[BUGFIX] Transfer curlProxyServer to new HTTP settings
- TYPO3_6-0 22654[TASK] Introduce use-statement for Utility-namespace in Bootstrap
- TYPO3_6-0 22651[BUGFIX] Detection of curlProxyServer settings is incorrect
- TYPO3_6-1 22650[BUGFIX] Detection of curlProxyServer settings is incorrect
- main 18481[BUGFIX] Detection of curlProxyServer settings is incorrect