#50913t3lib_div->trimExplode fills database table sys_log
Description
There are several uses of t3lib_div::trimExplode with wrong parameter types.
The second parameter must be a string, otherwise a php warning is stored to the sys_log database table, e.g. in t3lib_userAuth::getAuthInfoArray (line 1299) where the argument is an integer…
This could be easily resolved by this:
@@ -1282,20 1282,24 @@ t3lib_userAuth::getAuthInfoArray
function getAuthInfoArray() {
$authInfo = array();
$authInfo['loginType'] = $this->loginType;
$authInfo['refInfo'] = parse_url(t3lib_div::getIndpEnv('HTTP_REFERER'));
$authInfo['HTTP_HOST'] = t3lib_div::getIndpEnv('HTTP_HOST');
$authInfo['REMOTE_ADDR'] = t3lib_div::getIndpEnv('REMOTE_ADDR');
$authInfo['REMOTE_HOST'] = t3lib_div::getIndpEnv('REMOTE_HOST');
$authInfo['security_level'] = $this->security_level;
$authInfo['showHiddenRecords'] = $this->showHiddenRecords;
// can be overidden in localconf by SVCONF:
$authInfo['db_user']['table'] = $this->user_table;
$authInfo['db_user']['userid_column'] = $this->userid_column;
$authInfo['db_user']['username_column'] = $this->username_column;
$authInfo['db_user']['userident_column'] = $this->userident_column;
$authInfo['db_user']['usergroup_column'] = $this->usergroup_column;
$authInfo['db_user']['enable_clause'] = $this->user_where_clause();
- $authInfo['db_user']['checkPidList'] = $this->checkPid ? $this->checkPid_value : '';
+ $authInfo['db_user']['checkPidList'] = ($this->checkPid && $this->checkPid_value)
+ ? $this->checkPid_value
+ : '';
- $authInfo['db_user']['check_pid_clause'] = $this->checkPid ? ' AND pid IN (' . $GLOBALS['TYPO3_DB']->cleanIntList($authInfo['db_user']['checkPidList']) . ')' : '';
+ $authInfo['db_user']['check_pid_clause'] = ($this->checkPid && $this->checkPid_value)
+ ? ' AND pid IN (' . $GLOBALS['TYPO3_DB']->cleanIntList($authInfo['db_user']['checkPidList']) . ')'
+ : '';
$authInfo['db_groups']['table'] = $this->usergroup_table;
return $authInfo;
}Reviews 5
- TYPO3_6-0 24119[BUGFIX] Incomplete backup in AbstractUserAuthenticationTest
- TYPO3_4-7 24004[BUGFIX] Fix PHP warning trigged in getAuthInfoArray()
- TYPO3_6-0 24003[BUGFIX] Fix PHP warning trigged in getAuthInfoArray()
- TYPO3_6-1 24002[BUGFIX] Fix PHP warning trigged in getAuthInfoArray()
- main 22956[BUGFIX] Fix PHP warning trigged in getAuthInfoArray()