Issue Bug Closed

#50929Don't call rawurlencode() twice on curUrl

Jan Spisiak 08/08/13, 16:27 updated 09/11/13, 12:53

Description

In ElementBrowser.php:

$this->setTitle = $this->curUrlArray['title'] != '-' ? rawurlencode($this->curUrlArray['title']) : '';
...
$JScode = '
    ...
    var add_title="' . ($this->setTitle ? '&curUrl[title]=' . rawurlencode($this->setTitle) : '') . '";
    ...
';

This is for all curUrl attributes. In the end this means that javascript variables are encoded twice and the prefilled form is also encoded even if it shouldn’t be.
I’ve included patch, but I am not sure if it satisfies all the rules.

Reviews 0

No change resolves or names this issue in its commit message, and no comment links one.