#54085Replace all strcmp() calls with ===
Description
When testing for the identity of strings using the strcmp() function has worse performance than the === operator. (3-5x)
Replace all ~300 calls to strcmp() with the operator.
Attention: This is replacement only works when the return value of strcmp() is checked for being a boolean value, otherwise a string ordering is performed and the call MUST NOT be replaced!
The operator is also slower than the = operator, so use the latter one if possible.
Reviews 2
Related issues 5
- Task #54265Use (int) instead of intval() or (integer)
- Task #54517Replace substr() and strpos() with GeneralUtility::isFirstPartOfString when it makes sense
- Bug #56248 You can not add new records (TCA) in the edit mode
- Task #56393creation on new pages have broken permissions (perms_groupid set wrong)
- Bug #58525First usergroup from BE-user no longer applied to new pages