#54867pagetype shortcut check for internal loop
Description
Would be nice to prevent an internal error when setting up an shortcut-page that points to itself. This might avoid some ugly error throwout and make it more obvious for normal editors. Simple solution/suggestion: make it impossible to select the page you are currently working on.
Reviews 4
- TYPO3_8-7 58613[BUGFIX] pages.content_from_pid suggest wizard should not suggest itself
- main 58597[BUGFIX] pages.content_from_pid suggest wizard should not suggest itself
- TYPO3_8-7 58428[BUGFIX] pages.shortcut suggest wizard should not suggest itself
- main 58423[BUGFIX] pages.shortcut suggest wizard should not suggest itself
Related issues 2
History 13
-
Benni Mack changed project id category <span data-processor="relativetime" data-value="2016-10-20T15:44:01+00:00" > 10/20/16, 15:44 </span>
-
Riccardo De Contardi changed target version <span data-processor="relativetime" data-value="2017-04-25T16:18:28+00:00" > 04/25/17, 16:18 </span>
-
Josef Glatz changed Related to #86412 <span data-processor="relativetime" data-value="2018-09-28T06:28:15+00:00" > 09/28/18, 06:28 </span>
-
Riccardo De Contardi commented <span data-processor="relativetime" data-value="2018-10-07T23:08:08+00:00" > 10/07/18, 23:08 </span>
-
Josef Glatz commented <span data-processor="relativetime" data-value="2018-10-08T06:39:45+00:00" > 10/08/18, 06:39 </span>
I could imagine:
A) Show an error via MessageQueue if the actual edited page record links to it self. This informs an editor
B) what about extending the Record Browser with an additional argument where the value could be N tablename_<uid> like <code>pages_42</code>? Those ids are then disabled in the record browser (greyed out for example with a nice title attribute)</uid>
-
Josef Glatz changed removed the assignee target version <span data-processor="relativetime" data-value="2018-10-08T07:11:47+00:00" > 10/08/18, 07:11 </span>
-
Josef Glatz changed status
NewAccepted <span data-processor="relativetime" data-value="2018-10-08T07:12:57+00:00" > 10/08/18, 07:12 </span> -
Josef Glatz changed Related to #86600 <span data-processor="relativetime" data-value="2018-10-09T06:06:33+00:00" > 10/09/18, 06:06 </span>
-
Markus Klein commented <span data-processor="relativetime" data-value="2018-10-09T14:04:40+00:00" > 10/09/18, 14:04 </span>
I’d go with b)
-
Riccardo De Contardi commented <span data-processor="relativetime" data-value="2020-03-14T11:45:38+00:00" > 03/14/20, 11:45 </span>
I put here another idea: how about handling this with the link validator? Would it be a good idea or better not?
-
Susanne Moog changed category <span data-processor="relativetime" data-value="2020-03-25T13:45:40+00:00" > 03/25/20, 13:45 </span>
-
Benni Mack commented and changed status
AcceptedNeeds Feedback <span data-processor="relativetime" data-value="2025-03-25T13:54:03+00:00" > 03/25/25, 13:54 </span>We already have a check for a loop detection when resolving the page.
On the other hand, I’m not very keen on fixing things by “not showing the link to select”. I had this issue: Editor creates shortcut Page A to Page B, which is valid, then changes the page type to something else, then changes the doktype of Page b to have a shortcut to Page A again. You cannot prevent this at the time of setting this, but more during the time of resolving it.
The only option I see is: Have a warning in the page module when having a loop.
Linkvalidator will already report this IMHO anyways, as the link will never be able to be resolved.
-
Benni Mack commented and changed status
Needs FeedbackClosed <span data-processor="relativetime" data-value="2026-10-23T08:16:16+00:00" > 10/23/26, 08:16 </span>Closing this due to lack of feedback. If you want to continue, feel free to ping me or create a new issue.
Partially solved with #86412 – the suggest wizard skips the page itself; but it is still possible to select the same shortcut page as shortcut and save the record without errors or warnings.