Issue Task Closed

#55589Redundant method: ResourceCompressor::checkBaseDirectory

Michiel Roos 02/02/14, 14:17 updated 09/10/15, 09:21

Description

\TYPO3\CMS\Core\Resource\ResourceCompressor::checkBaseDirectory() is a thick wrapper around GeneralUtilty::isFirstPartOfStr().

It’s thick because it does not return the boolean result directly but first interprets is as a boolean and then returns TRUE or FALSE based on that.

On the login screen /typo3/, this method is called 110 times. The time spent inside the method (excluding isFirstPartOfStr() time) is 3.11 needless microseconds.

This wrapper method should be deprecated and the GeneralUtilty::isFirstPartOfStr() called directly.

Reviews 0

No change resolves or names this issue in its commit message, and no comment links one.