Issue Bug Closed

#55739typoLink() does not consider additional params for external urls

Markus Klein 02/06/14, 16:18 updated 07/18/15, 10:19

Description

The link wizard offers a field to specify additional link parameters.
This is encoded as fifth part into the link field.

When the link is rendered via ContentObjectRenderer::typoLink() this fifth part is evaluated but never used.

Affected are 6.0+ (did not check 4.x)

Reproduction

  • Use the link wizard on any content element (for instance header)
  • Set External URL
  • Set some additional parameter

Result

The additional params do not show up anywhere

Code

The code is evaluated here:

if (isset($link_paramA[4]) && strlen(trim($link_paramA[4])) > 0) {
    $forceParams = trim($link_paramA[4]);
    // params value
    $conf['additionalParams'] .= $forceParams[0] == '&' ? $forceParams : '&' . $forceParams;
}

But $conf['additionalParams'] is never used in the if body starting from line 5854.

Reviews 0

No change resolves or names this issue in its commit message, and no comment links one.