Issue Bug Closed

#61929DBAL: admin_query() produces wrong error, because it accesses 'TABLE' before check if query can be correctly parsed...

Robin Parker 09/28/14, 15:29 updated 10/02/18, 11:50

Description

Pseudo:
admin_query($query): // sysext/dbal/Classes/Database/DatabaseConnection.php – line 2863
$parsedQuery = parseSQL($query);
$ORIG_table = $parsedQuery[‘TABLE’]; // << here is the problem!
if (!is_array($parsedQuery)) {
throw new \InvalidArgumentException(‘ERROR: Query could not be parsed: “’ . htmlspecialchars($parsedQuery) . ‘”. Query: “’ . htmlspecialchars($query) . ‘”’, 1310027793);
}

Should be:
$parsedQuery = parseSQL($query);
if (!is_array($parsedQuery)) {
throw new \InvalidArgumentException(‘ERROR: Query could not be parsed: “’ . htmlspecialchars($parsedQuery) . ‘”. Query: “’ . htmlspecialchars($query) . ‘”’, 1310027793);
}
$ORIG_table = $parsedQuery[‘TABLE’];

Reviews 2