#62553Exception when accessing empty ObjectStorage property via numeric index
Description
Imagine a snippet like this within a Fluid template:
{product.images.0.title}
Given the images property is an ObjectStorage and empty, a warning exception is thrown:
> #1: PHP Warning: spl_object_hash() expects parameter 1 to be object, string given in /var/www/typo3_src/typo3/sysext/extbase/Classes/Persistence/ObjectStorage.php line 160
This is caused by the following steps:
- Fluid parser calls
\TYPO3\CMS\Fluid\Core\Parser\SyntaxTree\ObjectAccessorNode::getPropertyPath - The property “0” is not found via
\TYPO3\CMS\Extbase\Reflection\ObjectAccess::getPropertyInternal - The array check yields
TRUE(ObjectStorageimplements the\ArrayAccessinterface) isset($subject[$pathSegment])is calledObjectStorage::offsetExistsis called with"0"as argument- The call to
spl_object_hash("0")causes the warning
I am not sure who is at fault here but I can say the following:
- Accessing a non-existing property in Fluid should never trigger an error
- Implementing the
\ArrayAccessinterface means a promise to be capable of handling the only two natively supported index typesstringandinteger
Attached is a patch which performs a simple check via is_object.