Issue Bug Closed

#67204Calling DatabaseConnection::exec_SELECTgetRows() with an invalid $uidIndexField returns only a single row

Markus Klein 05/29/15, 23:17 updated 10/19/17, 21:25

Description

If one accidentally calls DatabaseConnection::exec_SELECTgetRows() with an invalid $uidIndexField, the method only returns a single record.

The reason is that the existence of the specified field is not verified. If the field is not set, the code

$output[$tempRow[$uidIndexField]] = $tempRow;

results in

$output[0] = $tempRow;

which simply overrides the first entry of the array. This happens for every record, hence finally only the last record of the query result is returned.

The method should check the $uidIndexField really exists and should throw an exception otherwise, in order to inform the developer of the mistake.

Reviews 1