#67492Clean up DataHandler
Description
DataHandler has a lot of hidden complexity in huge methods that nobody can fully grasp. Several aspects can be improved to make the class easier to handle, including:
- introduce early returns in methods/early continues in foreach loops, where possible
- split up long methods into smaller methods
- introduce parameter objects to get rid of overly long method signatures
All cleanups should keep the external interface intact for now, deprecation is allowed though.
See #67336 for one of the issues already created for this epic.
Reviews 0
No change resolves or names this issue in its commit message, and no comment links one.
Subtasks 12
- Task #67336Introduce early returns in DataHandler
- Task #67500Early loop continues in DataHandler::process_*
- Task #67510Split up DataHandler::copyRecord_procBasedOnFieldType()
- Task #67579Remove code duplication in DataHandler::copyRecord_processManyToMany()
- Task #67582Introduce early continue in DataHandler::copyRecord_fixRTEmagicImages()
- Task #67583Introduce early returns in DataHandler::localize()
- Task #67584Introduce early returns in DataHandler::fillInFieldArray()
- Bug #67585Introduce early returns in DataHandler::deleteRecord()
- Task #68207Introduce early returns in DataHandler::versionize()
- Task #68208Introduce early returns in DataHandler::inlineLocalizeSynchronize
- Task #68209Introduce early returns in DataHandler::checkValue_flex_procInData_travDS()
- Task #68775Introduce early returns in DataHandler::canDeletePage