Issue Task Closed

#69730Remove dot in uniqid('NEW', TRUE)

Christian Kuhn 09/12/15, 15:02 updated 10/19/17, 21:47

Description

DatabaseUniqueUidNewRow creates a “dummy” uid for new records. This is given to the DataHandler later, it then persists the new row and substitutes this placeholder with the real uid somehow.

Problem is, that the call uniqid(‘NEW’, TRUE) creates a string like “NEW12345678.1234567”. Mind the dot. This is triggered by the second argument as TRUE and makes sure that if uniqid() is called multiple times on windows, still a different result is returned. So, TRUE must be kept.

But: The dot is not a valid character in html attributes like id. so id=“NEW123.456” is invalid and gives headaches. Thus, there are some places hidden somewhere in element and container classes within FormEngine, that remove this dot again, if this one is used as id or at other places in DOM.

Task is: Do the removal of the dot in DatabaseUniqueUidNewRow once and for all, locate all within FormEngine that currently does that manually and remove these hacks.

Reviews 1