Issue Bug Closed

#70293Missing reference in "preprocessRequest" hook

Markus Hölzle 10/02/15, 10:24 updated 04/15/18, 11:21

Description

Hi,

I think the hook “$GLOBALS[‘TYPO3_CONF_VARS’][‘SC_OPTIONS’][‘tslib/index_ts.php’][‘preprocessRequest’]” should pass the reference of the calling object.

In \TYPO3\CMS\Frontend\Http\RequestHandler function handleRequest():

$hookParameters = array();
GeneralUtility::callUserFunction($hookFunction, $hookParameters, $hookParameters);

should be

$hookParameters = array();
GeneralUtility::callUserFunction($hookFunction, $hookParameters, $this);

The same issue is in \TYPO3\CMS\Frontend\Http\EidRequestHandler function handleRequest().
It would be great if the hook parameters are not empty… since TYPO3 7.5 we can pass the “ServerRequestInterface $request”. What do you think?

Markus

Reviews 0

No change resolves or names this issue in its commit message, and no comment links one.