Issue Bug Closed

#71621Change in PageRepository breaks overlaying of universal language records

Joschi Kuphal 11/17/15, 10:25 updated 10/02/18, 11:26

Description

For whatever reasons a change was made in PageRepository->getRecordOverlay(), effectively breaking the overlay of records with sys_language_uid = -1.

TYPO3 7.5 (typo3/sysext/frontend/Classes/Page/PageRepository.php line 488):

// Must be default language or [All], otherwise no overlaying:
if ($row[$GLOBALS['TCA'][$table]['ctrl']['languageField']] <= 0) {
    // ...
}

TYPO3 7.6 (typo3/sysext/frontend/Classes/Page/PageRepository.php line 484):

// Must be default language or [All], otherwise no overlaying:
if ((int)$row[$GLOBALS['TCA'][$table]['ctrl']['languageField']] === 0) {
    // ...
}

Mind the comment: “… default language or [All]” — doesn’t the comparison against === 0 explicitly exclude the all-languages setting?

The change completely breaks one of our sites, reverting the comparison back to <= 0 seems to fix it again however (at a first glance). There must have been a reason for this change though, right?

Reviews 1