Issue Bug Closed

#72407Extbase\DebuggerUtility::var_dump: blacklist does not work as expected

Tim Riemenschneider 12/23/15, 11:22 updated 10/02/18, 11:26

Description

When trying to blacklist classes/properties from the output, the first argument is ignored. This stems from the fact, that strpos is used in Extbase\DebuggerUtility::isBlacklisted.

I.e. when dumping a class:

class DumpMe {
   /** @var string */
   protected $secretData = 'do not show me';
   /** @var string */
   protected $showMe = 'show me in debug';
}

with DebuggerUtility::var_dump($myObj, 'Debug Test', 8, FALSE, TRUE, FALSE, null, array('secretData')); the secretData is still shown.

isBlacklisted contains:
@$result = (strpos(implode(‘|’, self::$blacklistedPropertyNames), $value->getName()) > 0);@
and since the string “secretData” is at position 0 in the imploded array, it is still shown.
dumping with DebuggerUtility::var_dump($myObj, 'Debug Test', 8, FALSE, TRUE, FALSE, null, array('dummy', 'secretData'));
or even with DebuggerUtility::var_dump($myObj, 'Debug Test', 8, FALSE, TRUE, FALSE, null, array('prefixDoesNotMattersecretData'));, it is hidden.

when using strpos, the return value should be checked with “@!== FALSE@”.

However, why is strpos even used here? why not $result = in_array($value->getName(), self::$blacklistedPropertyNames);
(maybe guarded by if(is_array...))

Reviews 3