Issue Bug Closed

#76031getPageOverlay Hook does not loop through pages by reference

Andreas Allacher 05/03/16, 15:57 updated 10/02/18, 11:13

Description

With the introduction of getPagesOverlay the page array is looped to pass each page to the getPageOverlay_preProcess hook:

foreach ($pagesInput as $origPage) {
                foreach ($GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['t3lib/class.t3lib_page.php']['getPageOverlay'] as $classRef) {
                    $hookObject = GeneralUtility::getUserObj($classRef);
                    if (!$hookObject instanceof PageRepositoryGetPageOverlayHookInterface) {
                        throw new \UnexpectedValueException('$hookObject must implement interface ' . PageRepositoryGetPageOverlayHookInterface::class, 1269878881);
                    }
                    $hookObject->getPageOverlay_preProcess($origPage, $lUid, $this);
                }
            }

However, as the foreach loop doesn’t use & before $origPage modified values in getPageOverlay_preProcess will never make it back to the original page array.

Reviews 2