Issue Bug Closed

#79128"Record history" is shown, even if hidden with TSConfig

Soren Malling 01/01/17, 22:50 updated 10/02/18, 11:04

Description

The tsconfig

options.showHistory = 0

is not respected in TYPO3\CMS\Backend\Controller\EditDocumentController in the getButtons() method in the making of the buttonbar.

Actually, a “Record History” buttons is being rendered twice but the TSconfig condition is only checked once.

In the first case, a condition only checks if there is any history

https://git.typo3.org/Packages/TYPO3.CMS.git/blob/HEAD:/typo3/sysext/backend/Classes/Controller/EditDocumentController.php#l1369

and then renders the button.

On line 1400

https://git.typo3.org/Packages/TYPO3.CMS.git/blob/HEAD:/typo3/sysext/backend/Classes/Controller/EditDocumentController.php#l1369

the condition is checked with the “getNewIconMode” method and respect if it’s hidden

Reviews 2