#81291Flash messages "info.elementAlreadyModified" added multiple times
Description
When visiting a record with Inline relations that has been sent to a review stage, the flash message with the label LLL:EXT:workspaces/Resources/Private/Language/locallang.xlf:info.elementAlreadyModified is added not only for the opened record itself, but for every inline record attached to it, that has been send to another stage.
This is because of the \TYPO3\CMS\Workspaces\Hook\BackendUtilityHook->makeEditForm_accessCheck hook not checking, if the message has already been added to the queue, or if the record that is checked is an inline record of the actual record.
I think the hook can not provide this functionality of not sending the message for inline records, because it can not know of this, because it gets no further information about the record it processes at that time.
The annoying thing about this is, that there will be as much flash messages as there are inline relations, rendering the edit view into a scroll fest.
One can test this by adding a simple record with file relations, creating a new workspaces stage by changing and saving it and sending it to another stage than \TYPO3\CMS\Workspaces\Service\StagesService::STAGE_EDIT_ID and finally revisiting the record.
Reviews 2
Related issues 1
History 49
-
Kevin Ditscheid changed Related to #81290 <span data-processor="relativetime" data-value="2017-05-22T10:07:32+00:00" > 05/22/17, 10:07 </span>
-
Benni Mack changed Sprint Focus On Location Sprint <span data-processor="relativetime" data-value="2023-08-02T14:55:54+00:00" > 08/02/23, 14:55 </span>
-
Georg Ringer changed Sprint Focus
On Location Sprint<span data-processor="relativetime" data-value="2026-08-06T15:49:28+00:00" > 08/06/26, 15:49 </span> -
Gerrit Code Review pushed patch set 1 for main to change 95368 status
NewUnder Review <span data-processor="relativetime" data-value="2026-08-19T13:08:37+00:00" > 08/19/26, 13:08 </span> -
Gerrit Code Review pushed patch set 2 for main to change 95368 <span data-processor="relativetime" data-value="2026-08-25T12:57:59+00:00" > 08/25/26, 12:57 </span>
-
Gerrit Code Review pushed patch set 3 for main to change 95368 <span data-processor="relativetime" data-value="2026-08-26T21:08:05+00:00" > 08/26/26, 21:08 </span>
-
Gerrit Code Review pushed patch set 1 for 14.3 to change 95618 <span data-processor="relativetime" data-value="2026-09-03T19:39:22+00:00" > 09/03/26, 19:39 </span>
-
Gerrit Code Review pushed patch set 2 for 14.3 to change 95618 <span data-processor="relativetime" data-value="2026-09-03T21:52:24+00:00" > 09/03/26, 21:52 </span>
-
Benjamin Kott commented and changed status
Under ReviewResolved done0 %100 % <span data-processor="relativetime" data-value="2026-09-03T22:15:11+00:00" > 09/03/26, 22:15 </span>
Applied in changeset commit:69a5ccc7c76526ac2f0b041a540fa72d621516e5.