Issue Bug Closed

#83476Few attributes are missing when concatenating JS files

Rune Piper 01/04/18, 18:50 updated 10/02/18, 10:53

Description

When using the config.concatenateJs = 1 option, the ResourceCompressor is loosing tag attributes such as the async attribute in the concatenateJsFiles method.
A fix would be to add 'async' => $fileOptions['async'] after line 201, but I guess, it’s too dirty for the core?!

Aside: Fresh installation with just tiny template:

config {
    concatenateJs = 1
}

page = PAGE
page.10 = TEXT
page.10.value = HELLO WORLD!
page.includeJSFooter {
    combined = path/to/file.css
    combined.async = 1
}

Reviews 1