Issue Bug Closed

#83740Cleanup of AbstractRecordList breaks hook

Frank Nägler 01/31/18, 15:17 updated 10/02/18, 10:51

Description

With #82334 the abstract parent class was removed.

This patch has some bad side effect:

1) In all three changed classes the same hook $GLOBALS[‘TYPO3_CONF_VARS’][‘SC_OPTIONS’][DatabaseRecordList::class][‘buildQueryParameters’] is used
2) the sixth parameter ($this) refer to one of this three classes, alle three classes has no common abstract parent class nor a common interface

The result: I have no change to write clean code, because I can’t add a type hint for the buildQueryParametersPostProcess method.
Beside this points, it is no good idea to use the same hook in different places with different method signatures.

Currently I would opt for an interface, the other solution would ne to revert the original patch.

Reviews 1