Issue Bug Closed

#84488linkvalidator failes on checking wrong links <a href="file://...

Sascha Maier 03/19/18, 21:35 updated 10/02/18, 10:51

Description

When checking links in RTE fields like:
<a href=“file://”….
the planer task and the module failes with message:
Folder … does not exits. 1314516810

Reason:
- only the FileDoesNotExistException is catched

linkvalidator/Classes/Linktype/FileLinktype.php:

 public function checkLink($url, $softRefEntry, $reference)
    {
        $resourceFactory = GeneralUtility::makeInstance(ResourceFactory::class);
        try {
            $file = $resourceFactory->retrieveFileOrFolderObject($url);
        } catch (FileDoesNotExistException $e) {
            return false;
        }
        return !$file->isMissing();
    }

Solution:
- additionally catch the FolderDoesNotExistException

public function checkLink($url, $softRefEntry, $reference)
    {
        $resourceFactory = GeneralUtility::makeInstance(ResourceFactory::class);
        try {
            $file = $resourceFactory->retrieveFileOrFolderObject($url);
        } catch (FileDoesNotExistException $e) {
            return false;
        } catch (FolderDoesNotExistException $e) {
            return false;
        }
        return !$file->isMissing();
    }

Reviews 2