Issue Bug Rejected

#85580Wrong call of method getRecordsToCopyDatabaseResult from Localisation Controller

Martin Horniak 07/17/18, 14:02 updated 07/30/18, 19:29

Description

In the LocalisationController in the Method getRecordUidsToCopy is a call to the Repository Method getRecordsToCopyDatabaseResult w2ith wrong number of arguments.
The definition of the calling Method has five arguments, where as fifth argument is a field list. But in the calee Method is ‘uid’ string as fourth argument used.

LocalisationController::getRecordLocalizeSummary (right call):

$result = $this->localizationRepository->getRecordsToCopyDatabaseResult(
            $params['pageId'],
            $params['colPos'],
            $params['destLanguageId'],
            $params['languageId'],
            '*'
        );

LocalisationController::getRecordUidsToCopy (wrong call):

$result = $this->localizationRepository->getRecordsToCopyDatabaseResult($pageId, $colPos, $languageId, 'uid');

Definition:

public function getRecordsToCopyDatabaseResult($pageId, $colPos, $destLanguageId, $languageId, $fields = '*')

Reviews 0

No change resolves or names this issue in its commit message, and no comment links one.