Issue Task Closed

#85610Remove skipped extbase text for argument not being array

Anja Leichsenring 07/21/18, 12:15 updated 10/02/18, 10:45

Description

typo3/sysext/extbase/Tests/Unit/Mvc/RequestTest.php::setArgumentThrowsExceptionIfTheGivenArgumentValueIsAnObject

is skipped since a long time.

Investigating why it would be advisable to deny the usage of objects in request arguments, I got this conclusions:

there are two places reading the incoming request arguments and using them.
- typo3/sysext/extbase/Classes/Mvc/Controller/AbstractController.php::mapRequestArgumentsToControllerArguments uses the argument to set it to the controller arguments and in this process, deals with incoming objects just fine.
- typo3/sysext/indexed_search/Classes/Controller/AdministrationController.php::processRequest uses the arguments to write the userSettings in writeUC(). This function takes incoming values and serializes them to store them in DB, is therefore able to handle objects just fine.

-> there is no reason to deny the usage of objects in extbase requests, therefor the (formely skipped) test can be deleted.

Reviews 1