Issue Bug Closed

#87845cacheHash.excludedParameters will be ignore when Enhancer is called

Alexey Atsyn 03/05/19, 13:40 updated 12/23/19, 22:48

Description

We detected a problem: when system called PluginEnhancer he wil call exception in the \TYPO3\CMS\Frontend\Controller\TypoScriptFrontendController::reqCHash function.
I’ve checked the code and find next:
PageArguments return all query parameters not from config as is and those parameters not compare with cacheHash.excludedParameters

We wrote next patch but don;;t sure is it correct solution:

    public function reqCHash()
    {
        $skip = false;
        if ($this->pageArguments !== null) {
            /** @var \TYPO3\CMS\Frontend\Page\CacheHashCalculator $cacheHashCalculator */
            $cacheHashCalculator = GeneralUtility::makeInstance(\TYPO3\CMS\Frontend\Page\CacheHashCalculator::class);
            $relevantParameters = $cacheHashCalculator->getRelevantParameters(
                http_build_query($this->pageArguments->getDynamicArguments(), '', '&', PHP_QUERY_RFC3986)
            );
            $skip = empty($relevantParameters);
        }
        ...

P.S.: we detected this problem with fbclid

Reviews 2