Issue Task New

#88627Unify DataProcessing properties

Łukasz Uznański 06/25/19, 15:28 updated 11/09/26, 11:24

Description

Hi,

I’m currently working with DataProcessors, and I can see some incoherence (or maybe I’m missing something). For each DataProcessor except LanguageMenu and Menu, parameter ‘as’ is required. LanguageMenu and Menu DataProcessor provides $menuDefaults, which provides default values for e.g. ‘as’ property, but for LanguageMenu, property $menuDefaults is protected, and for Menu, property is set to public.

I think we should set LanguageMenu $menuDefaults to public, and add property $menuDefaults with default values for required field e.g. ‘as’ (and maybe other) for other DataProcessors.

In other DataProcessors, default value is hardcoded in parameter for stdWrapValue.

Let me know what do you think, and I will create patch if necessary.

Reviews 1

Fix this issue

Start the commit message of your patch with this. Add what the patch does, and the versions it goes to in "Releases:". The changes above were merged or abandoned: read them before you start. How to create a patch

Commit message
[TASK] Unify DataProcessing properties Resolves: #88627 Releases: main

History 438

Show 313 earlier messages
  1. Jo Hasenau changed status New Accepted assigned to Jo Hasenau priority -- undefined -- Should have <span data-processor="relativetime" data-value="2019-10-22T14:35:16+00:00" > 10/22/19, 14:35 </span>

  2. Jo Hasenau commented <span data-processor="relativetime" data-value="2019-10-22T14:37:23+00:00" > 10/22/19, 14:37 </span>

    Since those changes might be breaking changes for former TYPO3 versions, we should not necessarily backport them to CMS 9 and 8.
    Still we should try to avoid breaking changes and if we managed to do so, we can still think about backporting them later on.

  3. Gerrit Code Review pushed patch set 1 for master to change 62082 status Accepted Under Review <span data-processor="relativetime" data-value="2019-10-23T14:38:31+00:00" > 10/23/19, 14:38 </span>