#88627Unify DataProcessing properties
Description
Hi,
I’m currently working with DataProcessors, and I can see some incoherence (or maybe I’m missing something). For each DataProcessor except LanguageMenu and Menu, parameter ‘as’ is required. LanguageMenu and Menu DataProcessor provides $menuDefaults, which provides default values for e.g. ‘as’ property, but for LanguageMenu, property $menuDefaults is protected, and for Menu, property is set to public.
I think we should set LanguageMenu $menuDefaults to public, and add property $menuDefaults with default values for required field e.g. ‘as’ (and maybe other) for other DataProcessors.
In other DataProcessors, default value is hardcoded in parameter for stdWrapValue.
Let me know what do you think, and I will create patch if necessary.
Reviews 1
Fix this issue
Start the commit message of your patch with this. Add what the patch does, and the versions it goes to in "Releases:". The changes above were merged or abandoned: read them before you start. How to create a patch
- Commit message
-
[TASK] Unify DataProcessing properties Resolves: #88627 Releases: main
History 438
Show 313 earlier messages
-
Jo Hasenau changed status
NewAccepted assigned to Jo Hasenau priority-- undefined --Should have <span data-processor="relativetime" data-value="2019-10-22T14:35:16+00:00" > 10/22/19, 14:35 </span> -
Jo Hasenau changed TYPO3 Version
910 <span data-processor="relativetime" data-value="2019-10-22T14:35:30+00:00" > 10/22/19, 14:35 </span> -
Gerrit Code Review pushed patch set 1 for master to change 62082 status
AcceptedUnder Review <span data-processor="relativetime" data-value="2019-10-23T14:38:31+00:00" > 10/23/19, 14:38 </span> -
Gerrit Code Review pushed patch set 2 for master to change 62082 <span data-processor="relativetime" data-value="2019-10-23T15:06:28+00:00" > 10/23/19, 15:06 </span>
-
Gerrit Code Review pushed patch set 3 for master to change 62082 <span data-processor="relativetime" data-value="2019-10-23T17:01:08+00:00" > 10/23/19, 17:01 </span>
-
Gerrit Code Review pushed patch set 4 for master to change 62082 <span data-processor="relativetime" data-value="2019-10-23T17:11:21+00:00" > 10/23/19, 17:11 </span>
-
Gerrit Code Review pushed patch set 5 for master to change 62082 <span data-processor="relativetime" data-value="2019-10-23T17:22:41+00:00" > 10/23/19, 17:22 </span>
-
Gerrit Code Review pushed patch set 6 for master to change 62082 <span data-processor="relativetime" data-value="2019-10-23T17:51:43+00:00" > 10/23/19, 17:51 </span>
-
Gerrit Code Review pushed patch set 7 for master to change 62082 <span data-processor="relativetime" data-value="2019-10-23T20:10:24+00:00" > 10/23/19, 20:10 </span>
-
Gerrit Code Review pushed patch set 8 for master to change 62082 <span data-processor="relativetime" data-value="2019-10-23T22:02:08+00:00" > 10/23/19, 22:02 </span>
-
Gerrit Code Review pushed patch set 9 for master to change 62082 <span data-processor="relativetime" data-value="2019-10-24T09:19:50+00:00" > 10/24/19, 09:19 </span>
-
Gerrit Code Review pushed patch set 10 for master to change 62082 <span data-processor="relativetime" data-value="2019-10-24T09:55:19+00:00" > 10/24/19, 09:55 </span>
-
Gerrit Code Review pushed patch set 11 for master to change 62082 <span data-processor="relativetime" data-value="2019-10-24T09:59:53+00:00" > 10/24/19, 09:59 </span>
-
Gerrit Code Review pushed patch set 12 for master to change 62082 <span data-processor="relativetime" data-value="2019-10-24T11:23:47+00:00" > 10/24/19, 11:23 </span>
-
Gerrit Code Review pushed patch set 13 for master to change 62082 <span data-processor="relativetime" data-value="2019-10-24T11:48:35+00:00" > 10/24/19, 11:48 </span>
-
Gerrit Code Review pushed patch set 14 for master to change 62082 <span data-processor="relativetime" data-value="2019-10-24T15:17:41+00:00" > 10/24/19, 15:17 </span>
-
Gerrit Code Review pushed patch set 15 for master to change 62082 <span data-processor="relativetime" data-value="2019-10-24T16:55:54+00:00" > 10/24/19, 16:55 </span>
-
Gerrit Code Review pushed patch set 16 for master to change 62082 <span data-processor="relativetime" data-value="2019-10-24T16:57:58+00:00" > 10/24/19, 16:57 </span>
-
Gerrit Code Review pushed patch set 17 for master to change 62082 <span data-processor="relativetime" data-value="2019-10-24T18:16:42+00:00" > 10/24/19, 18:16 </span>
-
Gerrit Code Review pushed patch set 18 for master to change 62082 <span data-processor="relativetime" data-value="2019-10-25T15:08:20+00:00" > 10/25/19, 15:08 </span>
-
Gerrit Code Review pushed patch set 19 for master to change 62082 <span data-processor="relativetime" data-value="2019-10-25T15:36:02+00:00" > 10/25/19, 15:36 </span>
-
Gerrit Code Review pushed patch set 20 for master to change 62082 <span data-processor="relativetime" data-value="2019-10-25T16:15:05+00:00" > 10/25/19, 16:15 </span>
-
Gerrit Code Review pushed patch set 21 for master to change 62082 <span data-processor="relativetime" data-value="2019-10-25T17:16:11+00:00" > 10/25/19, 17:16 </span>
-
Gerrit Code Review pushed patch set 22 for master to change 62082 <span data-processor="relativetime" data-value="2019-10-26T11:08:27+00:00" > 10/26/19, 11:08 </span>
-
Gerrit Code Review pushed patch set 23 for master to change 62082 <span data-processor="relativetime" data-value="2019-10-26T11:50:18+00:00" > 10/26/19, 11:50 </span>
-
Gerrit Code Review pushed patch set 24 for master to change 62082 <span data-processor="relativetime" data-value="2019-10-26T13:01:27+00:00" > 10/26/19, 13:01 </span>
-
Gerrit Code Review pushed patch set 25 for master to change 62082 <span data-processor="relativetime" data-value="2019-10-26T14:06:29+00:00" > 10/26/19, 14:06 </span>
-
Gerrit Code Review pushed patch set 26 for master to change 62082 <span data-processor="relativetime" data-value="2019-10-26T14:34:32+00:00" > 10/26/19, 14:34 </span>
-
Gerrit Code Review pushed patch set 27 for master to change 62082 <span data-processor="relativetime" data-value="2019-10-26T14:54:09+00:00" > 10/26/19, 14:54 </span>
-
Gerrit Code Review pushed patch set 28 for master to change 62082 <span data-processor="relativetime" data-value="2019-10-26T17:03:03+00:00" > 10/26/19, 17:03 </span>
-
Gerrit Code Review pushed patch set 29 for master to change 62082 <span data-processor="relativetime" data-value="2019-10-26T19:41:33+00:00" > 10/26/19, 19:41 </span>
-
Gerrit Code Review pushed patch set 30 for master to change 62082 <span data-processor="relativetime" data-value="2019-10-26T20:51:07+00:00" > 10/26/19, 20:51 </span>
-
Gerrit Code Review pushed patch set 31 for master to change 62082 <span data-processor="relativetime" data-value="2019-10-27T09:31:55+00:00" > 10/27/19, 09:31 </span>
-
Gerrit Code Review pushed patch set 32 for master to change 62082 <span data-processor="relativetime" data-value="2019-10-29T12:21:25+00:00" > 10/29/19, 12:21 </span>
-
Gerrit Code Review pushed patch set 33 for master to change 62082 <span data-processor="relativetime" data-value="2019-10-29T13:18:48+00:00" > 10/29/19, 13:18 </span>
-
Gerrit Code Review pushed patch set 34 for main to change 62082 <span data-processor="relativetime" data-value="2021-11-29T13:19:09+00:00" > 11/29/21, 13:19 </span>
-
Benni Mack changed status
Under ReviewNew <span data-processor="relativetime" data-value="2026-11-09T11:24:46+00:00" > 11/09/26, 11:24 </span>
Since those changes might be breaking changes for former TYPO3 versions, we should not necessarily backport them to CMS 9 and 8.
Still we should try to avoid breaking changes and if we managed to do so, we can still think about backporting them later on.