Issue Bug Closed

#89057Altering the arguments of a schedulable Symfony command that is configured in the Scheduler module breaks the module

S P 09/02/19, 11:16 updated 04/01/20, 21:14

Description

  1. Create a Symfony Command with arguments and register it.
  2. In teh Scheduler module add a task to execute console commands and select your command, save
  3. Remove one argument in the code again
  4. Open the Scheduler module
  5. Exception “The <removed argument name> argument does not exist.”</removed>

No way to recover from this via backend.

Problem is in sysext:scheduler/Classes/Task/ExecuteSchedulableCommandTask.php on line 113 where $input = new ArrayInput($this->getArguments(), $schedulableCommand->getDefinition()); is called. The defintion is read by Symfony fron the actual PHP file of the command, but the arguments are read from the additonal fields.

Some check whether the defintion has changed against the stored arguments has to happen there. Without such a check changing an existing task is basically not possible without breaking the scheduler (inducing manually fixing scheduler tasks via DB, not even a console command exists to fix such a state).

Reviews 2